New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#6918: Add auto mode to the lazy execution. #6919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyPavlenko
force-pushed
the
issue-6918
branch
2 times, most recently
from
February 6, 2024 15:24
a537217
to
68a5274
Compare
AndreyPavlenko
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev,
dchigarev and
a team
as code owners
February 6, 2024 16:21
dchigarev
reviewed
Feb 6, 2024
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
AndreyPavlenko
force-pushed
the
issue-6918
branch
from
February 6, 2024 20:16
68a5274
to
1fa38c5
Compare
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
AndreyPavlenko
force-pushed
the
issue-6918
branch
from
February 6, 2024 21:02
1fa38c5
to
384f243
Compare
YarShev
reviewed
Feb 6, 2024
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Show resolved
Hide resolved
modin/core/execution/ray/implementations/pandas_on_ray/partitioning/partition.py
Show resolved
Hide resolved
YarShev
approved these changes
Feb 6, 2024
dchigarev
approved these changes
Feb 7, 2024
anmyachev
reviewed
Feb 7, 2024
Comment on lines
125
to
126
If ``LazyExecution`` is enabled, the function is not applied immediately, | ||
but is added to the execution tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreyPavlenko should this also be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. To be removed in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date