Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#6932: don't use deprecated pandas._testing.makeStringIndex #6933

Merged
merged 1 commit into from Feb 16, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Feb 16, 2024

What do these changes do?

Same as in https://github.com/pandas-dev/pandas/pull/56155/files.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves ASV: AttributeError: module 'pandas._testing' has no attribute 'makeStringIndex' #6932
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…ringIndex'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
YarShev
YarShev previously approved these changes Feb 16, 2024
@YarShev YarShev dismissed their stale review February 16, 2024 14:13

asv is still failing

@anmyachev
Copy link
Collaborator Author

@YarShev
Copy link
Collaborator

YarShev commented Feb 16, 2024

I see. Will we fix all of the issues separately?

@anmyachev
Copy link
Collaborator Author

I see. Will we fix all of the issues separately?

Yes, that's the plan.

@YarShev YarShev merged commit 56fb47e into modin-project:master Feb 16, 2024
32 of 33 checks passed
@anmyachev anmyachev deleted the issue6932 branch February 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASV: AttributeError: module 'pandas._testing' has no attribute 'makeStringIndex'
2 participants