Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6952: use render_as_string to get sqlalchemy engine url #6953

Merged
merged 1 commit into from Feb 21, 2024

Conversation

tochigiv
Copy link
Contributor

@tochigiv tochigiv commented Feb 21, 2024

What do these changes do?

Instead of calling url.__str__(), call url.render_as_string() directly.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Worker nodes are given incorrect credentials from SQLAlchemy object URL #6952
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tochigiv, thanks for the contribution. Good to see that the changes fix the issue but left a question.

modin/core/io/sql/sql_dispatcher.py Show resolved Hide resolved
Copy link
Contributor

@sfc-gh-dpetersohn sfc-gh-dpetersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tochigiv , LGTM!

Copy link
Collaborator

@YarShev YarShev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tochigiv, LGTM, thanks!

@YarShev YarShev merged commit c422c78 into modin-project:master Feb 21, 2024
37 checks passed
@tochigiv tochigiv deleted the sqlalchemy-con-fix branch February 21, 2024 18:14
tochigiv added a commit to tochigiv/modin that referenced this pull request Feb 22, 2024
…ne url (modin-project#6953)

Signed-off-by: Bailey Brownie <bailey.brownie60@gmail.com>
tochigiv added a commit to tochigiv/modin that referenced this pull request Feb 22, 2024
…ne url (modin-project#6953)

Signed-off-by: Bailey Brownie <bailey.brownie60@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Worker nodes are given incorrect credentials from SQLAlchemy object URL
3 participants