Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6974: Always use actual pandas version in 'test_all_urls_exist' #6975

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Feb 28, 2024

What do these changes do?

The PR starts using PANDAS_API_URL_TEMPLATE that always contains an actual pandas version instead of raw urls (if the pandas version in the url doesn't match with the installed one, the test fails)

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Fix pandas version in test_all_urls_exist #6974
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…_urls_exist'

Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Comment on lines +51 to +52
for broken_method in methods_with_broken_urls:
doc_urls.remove(PANDAS_API_URL_TEMPLATE.format(broken_method))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for broken_method in methods_with_broken_urls:
doc_urls.remove(PANDAS_API_URL_TEMPLATE.format(broken_method))
for broken_url in methods_with_broken_urls:
doc_urls.remove(PANDAS_API_URL_TEMPLATE.format(broken_url))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it clearer?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? we're iterating over method names here, not urls

@YarShev YarShev merged commit f601f8a into modin-project:master Feb 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pandas version in test_all_urls_exist
2 participants