PERF-#6979: Do not trigger '._copartition()' for identical indices on binary operations #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al indices on binary operations Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
dchigarev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
anmyachev and
a team
as code owners
YarShev
reviewed
Feb 29, 2024
| the frames are empty. | ||
| """ | ||
| if isinstance(other, type(self)): | ||
| other = [other] | ||
|
|
||
| if not force_repartition and all( | ||
| o._check_if_axes_identical(self, axis) for o in other |
There was a problem hiding this comment.
o._check_if_axes_identical(self, axis) for o in other -> self._check_if_axes_identical(o, axis) for o in other? I am just wondering why the logic is inverted a bit?
There was a problem hiding this comment.
there's no reason for this, both of the options would perform identically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Check axes equality at the beginning of
._copartition()method using._check_if_axes_identical(), that supports computation-free comparison for sibling frames.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -s._copartition()on binary operations #6979docs/development/architecture.rstis up-to-date