Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6984: Ensure the results of inplace operations materialize (for tests) #6985

Merged
merged 4 commits into from Mar 1, 2024
Merged

FIX-#6984: Ensure the results of inplace operations materialize (for tests) #6985

merged 4 commits into from Mar 1, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Feb 29, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves In some cases, the results of inplace operations do not materialize. #6984
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#6984: Ensure the results of inplace operations mate…
58736fe 
…rialize (for tests)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
REVERT ME: run all tests
f74c253 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Revert "REVERT ME: run all tests"
f48cbee 
This reverts commit f74c253.
@anmyachev
modify test to be sure
a7aa615 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review March 1, 2024 10:06
@YarShev YarShev merged commit 2e5aba1 into modin-project:master Mar 1, 2024
36 checks passed
@anmyachev anmyachev deleted the issue6984 branch March 1, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@dchigarev dchigarev dchigarev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In some cases, the results of inplace operations do not materialize.
3 participants
@anmyachev @YarShev @dchigarev