Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#6892: Updating data in notebooks from yellow taxi to green taxi dataset #6993

Merged
merged 1 commit into from Mar 4, 2024

Conversation

arunjose696
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Dataset used in examples jupyter notebook is failing when jupyter notebook is run #6982?
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@arunjose696 arunjose696 changed the title FEAT-modin-project#6982: Updating data in notebooks from yellow taxi to green taxi dataset FIX-#6892: Updating data in notebooks from yellow taxi to green taxi dataset Mar 4, 2024
…failing when jupyter notebook is run

Signed-off-by: arunjose696 <arunjose696@gmail.com>
@YarShev YarShev merged commit 72adf5b into modin-project:master Mar 4, 2024
7 checks passed
@anmyachev
Copy link
Collaborator

@arunjose696 did you check all links to yellow taxi dataset?

@arunjose696
Copy link
Collaborator Author

arunjose696 commented Mar 4, 2024

In remaining links to yellow taxi I could observe they had not used fields like Dropoff_longitude which was only there in green_taxi, the other notebooks used fields such as total_amount,passenger_count,tpep_pickup_datetime,tpep_dropoff_datetime,trip_distance these were common to both datasets, so decided to keep yellow taxi dataset as is in other notebooks, should these be changed?

@anmyachev
Copy link
Collaborator

In remaining links to yellow taxi I could observe they had not used fields like Dropoff_longitude which was only there in green_taxi, the other notebooks used fields such as total_amount,passenger_count,tpep_pickup_datetime,tpep_dropoff_datetime,trip_distance these were common to both datasets, so decided to keep yellow taxi dataset as is in other notebooks, should these be changed?

No, in that case everything is fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset used in examples jupyter notebook is failing when jupyter notebook is run
3 participants