Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#7017: Align to_hdf and hist signatures to pandas #7018

Merged
merged 2 commits into from Mar 6, 2024
Merged

REFACTOR-#7017: Align to_hdf and hist signatures to pandas #7018

merged 2 commits into from Mar 6, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Mar 6, 2024 •
edited

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Align to_hdf and hist signatures to pandas #7017
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-modin-project#7017: Align 'to_hdf' and 'hist' signatures to …
b7305a2 
…pandas

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
anmyachev commented Mar 6, 2024
View reviewed changes
modin/pandas/dataframe.py
@@ -966,26 +972,28 @@ def gt(self, other, axis="columns", level=None): # noqa: PR01, RT01, D200
)

def hist(
self,
column=None,
data,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unusual, but otherwise the test with pandas will fail.

@anmyachev anmyachev marked this pull request as ready for review March 6, 2024 15:26
@YarShev YarShev merged commit bc25962 into modin-project:master Mar 6, 2024
37 checks passed
@anmyachev anmyachev deleted the issue7017 branch March 6, 2024 17:00
anmyachev added a commit to anmyachev/modin that referenced this pull request Mar 6, 2024
@anmyachev
REFACTOR-modin-project#7017: Align 'to_hdf' and 'hist' signatures to …
a64e5d1 
…pandas (modin-project#7018)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align to_hdf and hist signatures to pandas
2 participants
@anmyachev @YarShev