Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#7125: Explicitly install modin in ci tests #7126

Merged
merged 9 commits into from
Mar 26, 2024
Merged

TEST-#7125: Explicitly install modin in ci tests #7126

merged 9 commits into from
Mar 26, 2024

Conversation

dchigarev
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Explicitly call pip install modin in CI scripts #7125
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev
TEST-modin-project#7125: Explicitly install modin in ci tests
609a19e 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
remove 2.10.0 restriction
72cc3d9 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
second try
3c8b27b 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
third try
ec0a4c6 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
check result
de743f4 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
fix
3e42540 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
fix2
da50f60 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev
should work on windows
894c516 
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
@dchigarev dchigarev marked this pull request as ready for review March 26, 2024 12:16
YarShev
YarShev previously approved these changes Mar 26, 2024
View reviewed changes
YarShev
YarShev reviewed Mar 26, 2024
View reviewed changes
.github/actions/mamba-env/action.yml Outdated
@@ -42,3 +42,7 @@ runs:
# we set use-only-tar-bz2 to false in order for conda to properly find new packages to be installed
# for more info see https://github.com/conda-incubator/setup-miniconda/issues/264
use-only-tar-bz2: false
- shell: bash -el {0}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need -e flag? It looks like we only use -l everywhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied it from setup-miniconda docs. Removed -e, let's see if it works

@YarShev YarShev merged commit 4380eb7 into modin-project:master Mar 26, 2024
37 checks passed
@YarShev YarShev mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@anmyachev anmyachev Awaiting requested review from anmyachev anmyachev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly call pip install modin in CI scripts
2 participants
@dchigarev @YarShev