Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-#6890: Modin implementation of DataFrame API standard #7216

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 24, 2024

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add consortium DataFrame standard entrypoint #6890
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
docs/getting_started/installation.rst Outdated Show resolved Hide resolved
modin/tests/test_dataframe_api_standard.py Outdated Show resolved Hide resolved
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
@anmyachev anmyachev marked this pull request as ready for review April 25, 2024 10:13
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@@ -61,6 +61,7 @@ dependencies:
- isort>=5.12

- pip:
- git+https://github.com/data-apis/dataframe-api-compat.git@main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we expect a new release of dataframe-api-compat containing support for Modin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that I will have time to make a new release of this package before the new release of Modin. As a last resort, we will limit it to some working commit.

@YarShev YarShev merged commit 9ca33b4 into modin-project:main Apr 25, 2024
37 checks passed
@anmyachev anmyachev deleted the issue6890 branch April 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add consortium DataFrame standard entrypoint
2 participants