Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#7271: Remove instance_type attribute of axis partitions #7268

Merged
merged 1 commit into from
May 15, 2024
Merged

REFACTOR-#7271: Remove instance_type attribute of axis partitions #7268

merged 1 commit into from
May 15, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 14, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove instance_type attribute of axis partitions #7271
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title REFACTOR-#0000: Remove instance_type attribute of axis partitions REFACTOR-#7271: Remove instance_type attribute of axis partitions May 15, 2024
@anmyachev
REFACTOR-modin-project#7271: Remove 'instance_type' attribute of axis…
b535f12 
… partitions

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
anmyachev commented May 15, 2024
View reviewed changes
modin/core/dataframe/base/partitioning/axis_partition.py
@@ -95,8 +95,7 @@ def apply(
pass

# Child classes must have these in order to correctly subclass.
instance_type = None
partition_type = None
partition_type: Type
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix mypy error

@anmyachev anmyachev marked this pull request as ready for review May 15, 2024 12:09
@anmyachev anmyachev merged commit 8a62c3b into modin-project:main May 15, 2024
53 of 54 checks passed
@anmyachev anmyachev deleted the instance-type branch May 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove instance_type attribute of axis partitions
2 participants
@anmyachev @YarShev