Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quantile to list of Reductions #826

Conversation

devin-petersohn
Copy link
Collaborator

  • Removes a lot of unneeded code from implementation
  • Moves some of the pandas-specific metadata changes to the API layer
    • Names the result if it is a Series

What do these changes do?

Related issue number

  • passes flake8 modin
  • passes black --check modin
  • tests added and passing

* Removes a lot of unneeded code from implementation
* Moves some of the pandas-specific metadata changes to the API layer
  * Names the result if it is a `Series`
@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #826 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #826      +/-   ##
=========================================
- Coverage   91.81%   91.8%   -0.02%     
=========================================
  Files          42      42              
  Lines        5535    5526       -9     
=========================================
- Hits         5082    5073       -9     
  Misses        453     453
Impacted Files Coverage Δ
modin/backends/pandas/query_compiler.py 94.28% <100%> (+0.28%) ⬆️
modin/pandas/base.py 95.05% <100%> (+0.01%) ⬆️
modin/engines/ray/pandas_on_ray/frame/partition.py 88.23% <0%> (-1.18%) ⬇️
modin/engines/ray/generic/io.py 90.98% <0%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e6fea...062ae25. Read the comment docs.

@devin-petersohn devin-petersohn merged commit f15fb8e into modin-project:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant