fix for Python 3.7: re._pattern_type no longer exist #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* re._pattern_type was removed in Python 3.7. re.Pattern can be used instead. * Try re.Pattern first, and fall back to re._pattern_type otherwise.
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
=========================================
- Coverage 90.85% 90.8% -0.06%
=========================================
Files 47 47
Lines 5656 5656
=========================================
- Hits 5139 5136 -3
- Misses 517 520 +3
Continue to review full report at Codecov.
|
* Also add check in test_series.py to check for supported behavior in regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
instead.
Related issue number
flake8 modinblack --check modin(except for unrelated file)[ ] tests added and passing:Not applicable, tests are present, but they need to run with Python 3.7.