Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#99: Upgrade min python version #103

Merged
merged 2 commits into from Jan 27, 2022
Merged

FIX-#99: Upgrade min python version #103

merged 2 commits into from Jan 27, 2022

Conversation

YarShev
Copy link
Collaborator

@YarShev YarShev commented Jan 26, 2022

Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com

What do these changes do?

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves Upgrade min python version #99
  • tests passing
  • module layout described at docs/developer/architecture.rst is up-to-date

@YarShev
FIX-modin-project#99: Upgrade min python version
cf37d8c 
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
@YarShev
Copy link
Collaborator Author

YarShev commented Jan 26, 2022

Guys, are you aware of the failure for MPI backend with python 3.9?

@no-ponomarev
Copy link
Collaborator

no-ponomarev commented Jan 27, 2022 •
edited

Guys, are you aware of the failure for MPI backend with python 3.9?

As for me, no, something strange?

@prutskov
Copy link
Contributor

Guys, are you aware of the failure for MPI backend with python 3.9?

I've run only of 3.7/3.8

prutskov
prutskov reviewed Jan 27, 2022
View reviewed changes
setup.py Show resolved Hide resolved
@prutskov
Copy link
Contributor

I propose to add python3.9 testing in a separate PR, because this is out of the issue scope and requires more efforts.

@YarShev
Copy link
Collaborator Author

YarShev commented Jan 27, 2022

@prutskov, that sounds reasonable to me.

@YarShev
Exclude python 3.9 from testing
683e3b0 
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
@YarShev
Copy link
Collaborator Author

YarShev commented Jan 27, 2022

#104

@no-ponomarev
Copy link
Collaborator

LGTM, although some unrelated windows failure appeared

@YarShev
Copy link
Collaborator Author

YarShev commented Jan 27, 2022

test_get_ip is a common failure that we have in GH actions. I think we can keep it mind.

prutskov
prutskov approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@prutskov prutskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming CI is green

@prutskov
Copy link
Contributor

As decided, failures in get_ip test will be resolved later and it's not a stopper to merge (#53 (comment))

@prutskov prutskov merged commit f435c9a into modin-project:master Jan 27, 2022
@prutskov prutskov mentioned this pull request Jan 27, 2022
Merged
6 tasks
no-ponomarev added a commit to no-ponomarev/unidist that referenced this pull request Jan 28, 2022
@no-ponomarev
FEAT-modin-project#103 Add unidist main logo image
07cf387 
Signed-off-by: Nikita Ponomarev <nikita.ponomarev@intel.com>
@YarShev YarShev deleted the dev/yigoshev-issue99 branch June 9, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prutskov prutskov prutskov approved these changes

@no-ponomarev no-ponomarev Awaiting requested review from no-ponomarev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade min python version
3 participants
@YarShev @no-ponomarev @prutskov