Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#99: Upgrade min python version #103

Merged
merged 2 commits into from
Jan 27, 2022
Merged

FIX-#99: Upgrade min python version #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf37d8c
FIX-#99: Upgrade min python version
YarShev Jan 26, 2022
683e3b0
Exclude python 3.9 from testing
YarShev Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
shell: bash -l {0}
strategy:
matrix:
python-version: ["3.7", "3.8"]
python-version: ["3.8"]
backend: ["ray", "mpi", "dask", "multiprocessing", "python"]
env:
UNIDIST_BACKEND: ${{matrix.backend}}
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
shell: bash -l {0}
strategy:
matrix:
python-version: ["3.7", "3.8"]
python-version: ["3.8"]
backend: ["ray", "dask", "multiprocessing", "python"]
env:
UNIDIST_BACKEND: ${{matrix.backend}}
Expand Down
6 changes: 2 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import pathlib
from setuptools import setup, find_packages
import sys

YarShev marked this conversation as resolved.
Show resolved Hide resolved

here = pathlib.Path(__file__).parent.resolve()

Expand All @@ -10,8 +10,6 @@
ray_deps = ["ray[default]"]
dask_deps = ["dask[complete]>=2.22.0", "distributed>=2.22.0"]
mpi_deps = ["mpi4py-mpich", "msgpack"]
if sys.version_info[1] < 8:
mpi_deps += "pickle5"
all_deps = ray_deps + dask_deps + mpi_deps

setup(
Expand All @@ -32,5 +30,5 @@
"all": all_deps,
},
entry_points={"console_scripts": ["unidist = unidist.cli.__main__:main"]},
python_requires=">=3.7.1",
python_requires=">=3.8",
)
11 changes: 1 addition & 10 deletions unidist/core/backends/mpi/core/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,9 @@

import importlib
import inspect
import sys

# Serialization libraries
if sys.version_info[1] < 8: # check the minor Python version
try:
import pickle5 as pkl
except ImportError:
raise ImportError(
"Missing dependency 'pickle5'. Use pip or conda to install it."
) from None
else:
import pickle as pkl
import pickle as pkl
import cloudpickle as cpkl
import msgpack
import gc # msgpack optimization
Expand Down