Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to specify "--bind-services" option for create-runtime-image goal. #129

Closed
jaygazula27 opened this issue Oct 18, 2020 · 4 comments
Closed

Ability to specify "--bind-services" option for create-runtime-image goal. #129

jaygazula27 opened this issue Oct 18, 2020 · 4 comments

Comments

@jaygazula27
Copy link
Contributor

This plugin has been so useful for modular applications, but I hit a snag recently when one of my dependencies was trying to use the service provider functionality.
Would it be possible to add the --bind-services flag as part of the create-runtime-image goal?

Documentation is provided here: https://docs.oracle.com/javase/9/tools/jlink.htm#JSWOR-GUID-CECAC52B-CFEE-46CB-8166-F17A8E9280E9

Thank you!
@gunnarmorling
Copy link
Member

Happy to hear ModiTect is useful to you, thanks! Re your suggestion, sure, that sounds reasonable. Would you be interested in sending a PR for it?

@jaygazula27
Copy link
Contributor Author

jaygazula27 commented Oct 18, 2020 •
edited

Sure! Just sent the PR.
#130

@gunnarmorling
Copy link
Member

Sweet, thx. Not sure yet when we'll do the next release (CC @siordache); in the meantime you could simply build from source of course.

@jaygazula27
Copy link
Contributor Author

Yep, sounds good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gunnarmorling @jaygazula27