Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GCC 10.2 #3

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Update to GCC 10.2 #3

merged 3 commits into from
Sep 5, 2020

Conversation

rleh
Copy link
Member

@rleh rleh commented Sep 4, 2020

...and build into /opt/avr-gcc instead of /work/avr-gcc.

@rleh rleh requested a review from salkinium September 4, 2020 21:33
salkinium
salkinium approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, installing in /opt is a much, much better choice!

@salkinium
Copy link
Member

You'll probably have to adapt some PATH's somewhere now though!

@rleh
Copy link
Member Author

rleh commented Sep 4, 2020

Here: https://github.com/modm-ext/docker-modm-build/blob/master/Dockerfile#L45

@salkinium
Copy link
Member

Could you perhaps add a simple install instruction to the readme, so that people coming from the modm homepage don't get stuck.

@rleh
Copy link
Member Author

rleh commented Sep 4, 2020

I like it, installing in /opt is a much, much better choice!

The idea is a result of your comment: modm-io/modm#456 (comment)

I hope the compiled version is usable on other machines, let's try...

@rleh
Copy link
Member Author

rleh commented Sep 4, 2020

I've pushed ca7467e to master, a Dockerhub build already is running to update the modm/avr-gcc-prerequisites container to Ubuntu 20.04.

Updated README will be pushed once Dockerhub is done.

@rleh rleh merged commit 39e7017 into master Sep 5, 2020
@rleh rleh deleted the gcc-10-2-0 branch September 5, 2020 00:12
@rleh rleh mentioned this pull request Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rleh @salkinium