-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ATSAM arm processors (continued) #31
Conversation
f6a7065
to
81a7bd1
Compare
I found time and motivation to move this forward, @CrustyAuklet. I'm now merging this code as is, since apart from more devices there's absolutely every right with it. I'll add more devices in future if I feel like it 😊. I've moved/copied your cmsis-header-atsam repo to modm-io/cmsis-header-sam and will be maintaining it from there as part of your modm integration. I hope that's ok with you. BTW, congrats on xmega-cpp17, it's very well done and I love that you applied the principles of data extraction -> templates -> C++ code for your specific problem. This is exactly the solutions I wanted to inspire, to slowly change the tide toward better HALs! |
81a7bd1
to
a8c1458
Compare
Can't believe it's been a year! Yea sorry, I just haven't had the bandwidth to take the lead on this. I am fully sold on HAL generation after the work I did though. I really love all the work you've done with modm. I threw some alerts on the SAM issues here, so maybe I can help if I get a chance between everything else. Thanks for the compliment on my XMega project. It worked out really well in profiling and compiled size. Unfortunately our legacy code that runs on those cores is very tightly coupled to the old HAL. I am looking at doing something similar with an STM32 and will probably use modm-devices as the data source. 😄 |
Don't worry, you've already done the heavy lifting, and made it much easier for me to add the missing bits! I already have hacked GPIO working over here with bossac bootloader integration.
Ok, my long-term plan here is to move a lot of the data conversion code Python code currently copied and pasted everywhere in the modm modules into this repo as a shared code base. This includes things like "give the the port names", "max IRQ number", "all peripheral names that can be connected via GPIO" etc. So things that can "easily" be derived from the data, but are not explicitly stored to keep the device files light. So don't hesitate to change modm-devices to your needs, even if just in your fork, I love to check out how devs like you use this for their purpose! |
Continuation of the work in #19 by @CrustyAuklet.
TODO:
Add more SAM familiesBetter grouping of device files (?)