[math] added initializer_list initialization to matrix #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No, I think we came to the conclusion that we only change the formatting if we refactor the entire file completely. |
|
Sure 😵💫 undid the |
|
Maybe also not so super relevant to merge this, if the modm custom matrix math is abandoned anyways.. |
Kinda depends how long you can wait, cos I'm not very certain if eigen can really be intergrated until I try it. |
|
@hshose I have committed the review suggestion to run the CI. Please test if the code works for you. |
|
Yap, works, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added constructor with initializer list to
modm::math::Matrixclass.The huge diff is from the clang-format script... Not sure if you want to have this?