Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCP3008 SPI ADC driver #1028

Merged
merged 2 commits into from Jun 3, 2023
Merged

MCP3008 SPI ADC driver #1028

merged 2 commits into from Jun 3, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented May 25, 2023 •
edited

  • Driver
  • Example
  • Test example

@chris-durand chris-durand added this to the 2023q2 milestone May 25, 2023
@rleh rleh self-requested a review June 1, 2023 15:35
rleh
rleh approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏽

@chris-durand
Copy link
Member Author

I have tested the driver with actual hardware and it's working.

salkinium
salkinium approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please merge cos I'm AFK.

@rleh rleh merged commit eda224e into modm-io:develop Jun 3, 2023
13 checks passed
@chris-durand chris-durand deleted the feature/mcp3008 branch June 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh rleh approved these changes

Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris-durand @salkinium @rleh