Catch missing printf implementation #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
force-pushed
the
fix/silent_missing_printf
branch
from
2cd36cc
to
1fb1584
Compare
Accidental use of printf will use the Newlib implementation which uses heap, thus causing an error message about missing :platform:heap module.
salkinium
force-pushed
the
fix/silent_missing_printf
branch
from
1fb1584
to
7318c28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidental use of printf will use the Newlib implementation which uses heap, thus causing an error message about missing
:platform:heapmodule. This is confusing and will lead to an unnecessary usage of the heap in addition to not getting any printf output.This adds a dummy implementation of all printf methods and places them into a
/DISCARD/section just like the heap functions.