Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stm32] Extend Timer features: PWM modes, Break Input and Comparator #1134

Merged
merged 2 commits into from Mar 8, 2024
Merged

[stm32] Extend Timer features: PWM modes, Break Input and Comparator #1134

merged 2 commits into from Mar 8, 2024

Conversation

victorandrehc
Copy link
Contributor

  1. Add PWM Modes
  2. Add output configure channels on timer
  3. Fixes the register field size for the repetition counter register
  4. Break Input on Timers
  5. Implementation for comparator in the g0

salkinium
salkinium reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes from me, but I can only judge syntax, since I don't know much about the Timer hardware.

@salkinium salkinium added this to the 2024q1 milestone Mar 1, 2024
chris-durand
chris-durand approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Mar 6, 2024
@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Mar 7, 2024
@salkinium salkinium merged commit a371df6 into modm-io:develop Mar 8, 2024
39 checks passed
@rleh

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium left review comments

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈
Milestone
2024q1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@victorandrehc @rleh @salkinium @chris-durand