Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter::MovingAverage::reset(), maintenance of code #872

Merged
merged 1 commit into from Jun 8, 2022

Conversation

TomSaw
Copy link
Contributor

@TomSaw TomSaw commented Jun 7, 2022

Hope you see the potential.
I also have maintained the code slightly.

TODO

  • Add test for filter::MovingAverage::reset()

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@TomSaw TomSaw force-pushed the feature/moving-average-reset branch from f34f562 to bc038af Compare June 7, 2022 20:06
@TomSaw
Copy link
Contributor Author

TomSaw commented Jun 7, 2022

Test is in the box - ready to merge if you are.

src/modm/math/filter/moving_average.hpp Outdated Show resolved Hide resolved
src/modm/math/filter/moving_average.hpp Outdated Show resolved Hide resolved
src/modm/math/filter/moving_average_float_impl.hpp Outdated Show resolved Hide resolved
src/modm/math/filter/moving_average_float_impl.hpp Outdated Show resolved Hide resolved
@TomSaw TomSaw force-pushed the feature/moving-average-reset branch 2 times, most recently from ceadad9 to bf2de73 Compare June 8, 2022 14:27
src/modm/math/filter/moving_average.hpp Outdated Show resolved Hide resolved
src/modm/math/filter/moving_average.hpp Outdated Show resolved Hide resolved
src/modm/math/filter/moving_average.hpp Outdated Show resolved Hide resolved
test/modm/math/filter/moving_average_test.cpp Outdated Show resolved Hide resolved
@TomSaw TomSaw force-pushed the feature/moving-average-reset branch from bf2de73 to cfb69bd Compare June 8, 2022 19:23
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

(the submodules got updated by accident, but the rest is fine)

@TomSaw TomSaw force-pushed the feature/moving-average-reset branch from cfb69bd to 7b5827f Compare June 8, 2022 19:59
@salkinium salkinium merged commit 7b5827f into modm-io:develop Jun 8, 2022
@salkinium salkinium added this to the 2022q2 milestone Jun 8, 2022
@TomSaw TomSaw deleted the feature/moving-average-reset branch June 13, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants