[stm32] Fix stm32-extended I2C driver NACK handling #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detach transaction after completion of STOP condition when NACK was received.
|
@salkinium Did you do anything to fix the Mac CI? It has suddenly started working again. |
No, but the macOS image was updated from 20230117.3 to 20230120.1, so I guess the thing that magically broke the CI got magically fixed. Interestingly, I cannot yet find the 20230120.1 release on their release page, so who knows what got updated. |
You can probably take out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946.
With the fix after reception of a NACK the transaction is detached only after transmitting the stop condition is completed.
Tested in hardware on Nucleo-L031K6 with example from issue #946 and on a custom STM32L431RC board with connected I2C devices.