Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setter for rcr register #981

Merged
merged 2 commits into from Mar 19, 2023

Conversation

victorandrehc
Copy link
Contributor

As discussed here this PR creates a method to set the RCR register on advanced timers.

On the end I prefered to create it on advanced.hpp because it is where methods changing registers are located.

@victorandrehc victorandrehc force-pushed the feature/set_rcr_register branch 2 times, most recently from a26c75b to 8f34911 Compare March 15, 2023 19:18
@victorandrehc victorandrehc marked this pull request as ready for review March 15, 2023 20:07
@salkinium
Copy link
Member

You can also add an small example if you want, then the API actually gets tested.

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@salkinium salkinium merged commit 740fd51 into modm-io:develop Mar 19, 2023
@salkinium salkinium added this to the 2023q1 milestone Mar 19, 2023
@victorandrehc victorandrehc deleted the feature/set_rcr_register branch February 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants