Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[driver] Add MAX31865 driver with STM32F469 Discovery example #993

Merged
merged 2 commits into from May 2, 2023
Merged

[driver] Add MAX31865 driver with STM32F469 Discovery example #993

merged 2 commits into from May 2, 2023

Conversation

hshose
Copy link
Contributor

@hshose hshose commented Apr 6, 2023 •
edited

  • Driver
  • Example with F469
  • Works with Hardware
  • README

@chris-durand chris-durand self-requested a review April 6, 2023 23:38
@hshose hshose force-pushed the feature/max31865 branch 3 times, most recently from da7f71b to e79d56f Compare April 6, 2023 23:49
rleh
rleh reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice driver!

Please use tabs instead of spaces.

rleh
rleh reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver is (correctly) named max31865, but example max31855.

examples/stm32f469_discovery/max31855/main.cpp Outdated Show resolved Hide resolved
@rleh rleh added this to the 2023q2 milestone Apr 7, 2023
@hshose hshose force-pushed the feature/max31865 branch 3 times, most recently from efeff65 to b1105be Compare April 7, 2023 09:34
salkinium
salkinium requested changes Apr 8, 2023
View reviewed changes
examples/stm32f469_discovery/max31865/main.cpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31865_impl.hpp Outdated Show resolved Hide resolved
@hshose hshose force-pushed the feature/max31865 branch 2 times, most recently from 48f8bde to eaff392 Compare April 9, 2023 09:16
@hshose
Copy link
Contributor Author

hshose commented Apr 9, 2023

Thanks @salkinium und @rleh for the review.

Please don't merge yet - I havent tested the fixes with hardware yet.

@rleh
Copy link
Member

rleh commented Apr 9, 2023

@hshose I pushed some commits to your branch, because it was too confusing to explain this in code comments.
Feel free to delete the commits from your branch if you don't like them.

@chris-durand chris-durand mentioned this pull request Apr 16, 2023
Merged
13 tasks
@salkinium
Copy link
Member

If it's not too annoying, could you try out your changed on top of #1001 and check if these "weird" issues dissappear?

rleh
rleh approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@hshose
Copy link
Contributor Author

hshose commented May 2, 2023

If it's not too annoying, could you try out your changed on top of #1001 and check if these "weird" issues dissappear?

If I also add the :processing:protothread:use_fiber option it works and fixes #1012.
I assume you wanted to mention this under #1012?

@hshose hshose requested a review from salkinium May 2, 2023 21:49
chris-durand
chris-durand approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salkinium salkinium merged commit 65bbccf into modm-io:develop May 2, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh rleh approved these changes

@chris-durand chris-durand chris-durand approved these changes

Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2023q2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hshose @rleh @salkinium @chris-durand