Command: Avatar #3333
Open
Command: Avatar #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4.1.0 Release
This PR implements a command for owners to update their bot avatar directly in discord. Co-Authored-By: Cyrus Yip <54488650+RealCyGuy@users.noreply.github.com>
CL/CD errors fix Co-Authored-By: Cyrus Yip <54488650+RealCyGuy@users.noreply.github.com>
Co-Authored-By: Cyrus Yip <54488650+RealCyGuy@users.noreply.github.com>
raidensakura
added a commit
to raidensakura/modmail
that referenced
this pull request
Mar 31, 2024
| await self.bot.user.edit(avatar=dc_avatar) | ||
| logger.info("Bot Avatar updated.") | ||
| except Exception: | ||
| raise ValueError("Uploading the avatar to discord failed.") |
There was a problem hiding this comment.
This doesn't look like it handles the exception gracefully, the command will just error silently giving no feedback to the user indicating the command has failed. Ideally this also should invoke @trigger_typing since it could take a few seconds to complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an avatar command to the bot which makes it possible for owners to change the bots avatar directly via a command.