Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm thread creation #2773

Closed
khionu opened this issue Mar 4, 2020 · 18 comments · Fixed by #2875
Closed

Confirm thread creation #2773

khionu opened this issue Mar 4, 2020 · 18 comments · Fixed by #2875
Labels
approved config suggestion New config option staged Staged for next version

Comments

@khionu
Copy link

khionu commented Mar 4, 2020

Is your feature request related to a problem? Please describe.
We're getting a lot of threads started by people who won't bother to read anything and just send the bot a message like "hi", not realizing we take this very seriously.

Describe the solution you'd like
A confirmation before starting the thread, in the form of a message with reactions for confirm/cancel.

Describe alternatives you've considered
Command instead of reactions.

Note, I'm already working on adding this feature to the bot, but if this can be approved, I would like some help discussing a minor blocker I found in the bot structure, and then I can PR it.

@StephenDaDev
Copy link
Member

Hey! Thanks for leaving feedback, without user feedback and suggestions Modmail wouldn't be where it is today.

While this suggestion is greatly appreciated a better way to implement this would probably be in #398 (Accidental Threads) as this only filters certain messages allowing users who know how the system works to just DM and not have to deal with a confirmation every time they'd like to contact the support team via the bot.

@kantenkugel
Copy link

Just my two cents:

I think that keeping a list of words to ignore, or trying to figure out what should start one vs what shouldn't is probably way too hard or not feasible. Therefore, a Command or reaction seems like the better solution for me.

This would only be needed to start a thread and the bot could just give some information like"There is no active Thread. Do you want to start one?" together with either the command or reaction possibility.

I don't think that this is too high of an entry barrier, considering users usually super rarely wanting to actually create a modmail thread, the bot helping out with creating and you only having to do it once per Thread

@StephenDaDev
Copy link
Member

That's with your usage, for servers who use modmail MUCH MORE (I have over 300 threads in about a month) this will start to be a pain. This helps some server but causes issues for others

@khionu
Copy link
Author

khionu commented Mar 4, 2020

In the work I've been doing locally, I added it as a configuration. I have no opinion on it being on or off by default, but I think it would be a nice feature.

300 threads over a month is significant, sure, but this overhead concern would be felt on a per-thread basis on the user side. That said, it would be easy enough to make it a one-time check. UserId -> DateTime, so if the message gets updated they have to agree again.

Are there other concerns that you have? I'd be happy to address concerns until the idea is in a state where you'd be welcome to have it submitted.

@StephenDaDev
Copy link
Member

One time could be helpful, when that concept is brought in it becomes more logical

@khionu
Copy link
Author

khionu commented Mar 5, 2020

Alright! I'll have a PR open in a couple days.

@khionu
Copy link
Author

khionu commented Mar 5, 2020

I assume you'd rather have the default as "off"?

@Aloqeely
Copy link
Contributor

Aloqeely commented Mar 5, 2020

I assume you'd rather have the default as "off"?

Yeah probably

@Taaku18 Taaku18 added the config suggestion New config option label Mar 10, 2020
@github-actions
Copy link

This issue is stale because it has been open for 100 days with no activity. Remove stale label or comment or this will be closed in 5 days. Please do not un-stale this issue unless it carries significant contribution.

@github-actions github-actions bot added the Stale label Jun 19, 2020
@khionu
Copy link
Author

khionu commented Jun 19, 2020

I was never able to get around to finishing this feature, but it's still relevant.

@khionu
Copy link
Author

khionu commented Jun 25, 2020

Can I get this reopened, please? It's still relevant.

@Markus2809

This comment has been minimized.

@fourjr fourjr reopened this Jun 27, 2020
@github-actions github-actions bot closed this as completed Jul 3, 2020
@khionu
Copy link
Author

khionu commented Jul 3, 2020

Can someone reopen this and also remove the Stale label?

@Anonymyous678
Copy link

👍 I agree with this

@fourjr fourjr removed the Stale label Aug 9, 2020
@fourjr fourjr reopened this Aug 9, 2020
@ririko5834
Copy link

I like this feature request. This would be great, please add it.

@Anonymyous678
Copy link

Why someone who is a good python dev can't code this? 🙏

@Anonymyous678
Copy link

@khionu When you will make PR?

@fourjr
Copy link
Collaborator

fourjr commented Nov 5, 2020

Added to v3.6.3-dev2 which is still in development. Will be ready for public release soon.

@fourjr fourjr linked a pull request Nov 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved config suggestion New config option staged Staged for next version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants