Prevent category names in elements extract #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuuti
changed the title
|
Looks to be working as intended when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
Do not extract category names into elements any more, instead keep the ids. In order to not introduce a BC suddenly to existing installations, adds a config option
category_ids_in_elementswhich needs to be set to true in .gitify file to activate ids in favor of names.Why is it needed ?
There are problems when categories have the same names.
Related issue(s)/PR(s)
I see that just as an intermediate solution - i prefer having #165 being implemented, as this would give much more file "overview" in larger projects and reflect the tree like structure in the manager better (same as with resources/content, which is already extracted into folders)