Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splited SugarRecordResults logic #99

Merged
merged 5 commits into from Dec 29, 2014
Merged

Splited SugarRecordResults logic #99

merged 5 commits into from Dec 29, 2014

Conversation

pepicrft
Copy link

What?

  • Resolves SugarRecordResults import Realm #98
    When I implemented SugarRecordResults I didn't take into account that Realm and CoreData logic should be separated to not force CoreData users to have Realm or viceversa.
    Thanks @foxling for the report

Steps

  • Implement the new logic
  • Ensure the code is properly documented
  • Review style-guidelines
  • Tests for the new logic added and passings
  • Ensure that the local continuous integration script passes

Gif

gif

@pepicrft pepicrft self-assigned this Dec 29, 2014
@pepicrft pepicrft added this to the 1.0.5 milestone Dec 29, 2014
@pepicrft pepicrft changed the title [WIP] Splited SugarRecordResults logic Splited SugarRecordResults logic Dec 29, 2014
pepicrft pushed a commit that referenced this pull request Dec 29, 2014
@pepicrft pepicrft merged commit 7d93d6b into develop Dec 29, 2014
@pepicrft pepicrft deleted the bug/resultsDependency branch December 29, 2014 00:16
@foxling
Copy link
Contributor

foxling commented Dec 29, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants