Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: run bash explicitly for migration #2717

Merged
merged 1 commit into from Jan 10, 2023
Merged

docs: run bash explicitly for migration #2717

merged 1 commit into from Jan 10, 2023

Conversation

nicosqc
Copy link
Contributor

@nicosqc nicosqc commented Dec 21, 2022

hope this is sufficient, else let me know if you would change something. Bash won't be a login shell but since we clear the enviroment with sudo -i this should not have any meaningful impact

@Spitfireap
Copy link
Member

Thanks, it will help, surely. There are a few others sudo -i across the documentation, would you mind editing all of them ? :)

Since the default shell is set to /bin/sh, running 'source' to load the virtualenv won't work right away as described in the docs. You need to start bash (or a compatible shell) since sh does not feature the 'source' builtin. This addresses modoboa/modoboa-installer#463
@nicosqc nicosqc closed this Jan 3, 2023
@nicosqc
Copy link
Contributor Author

nicosqc commented Jan 3, 2023

struggled with my local branch for a bit there (and github closed it therefore) but updated the fork to change all occurrences

@nicosqc nicosqc reopened this Jan 3, 2023
@nicosqc
Copy link
Contributor Author

nicosqc commented Jan 3, 2023

something went wrong idk. why does it say i force pushed to 572e32f when i added https://github.com/nicosqc/modoboa/commit/21bf16317c4acece6c498365d1229e4dab65031f

€: oh well, guess it's fine cause changed files and commits have my edits, seems like thats just an old state from me messing with my branch

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #2717 (21bf163) into master (91e779b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files         211      211           
  Lines       11089    11089           
  Branches     1727     1727           
=======================================
  Hits         9146     9146           
  Misses       1459     1459           
  Partials      484      484           

@tonioo tonioo merged commit 1307ec4 into modoboa:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants