docs: run bash explicitly for migration#2717
Merged
tonioo merged 1 commit intomodoboa:masterfrom Jan 10, 2023
nicosqc:docs-migration-patch
Merged
docs: run bash explicitly for migration#2717tonioo merged 1 commit intomodoboa:masterfrom nicosqc:docs-migration-patch
tonioo merged 1 commit intomodoboa:masterfrom
nicosqc:docs-migration-patch
Conversation
Member
|
Thanks, it will help, surely. There are a few others |
Since the default shell is set to /bin/sh, running 'source' to load the virtualenv won't work right away as described in the docs. You need to start bash (or a compatible shell) since sh does not feature the 'source' builtin. This addresses modoboa/modoboa-installer#463
Contributor
Author
|
struggled with my local branch for a bit there (and github closed it therefore) but updated the fork to change all occurrences |
Contributor
Author
|
something went wrong idk. why does it say i force pushed to 572e32f when i added https://github.com/nicosqc/modoboa/commit/21bf16317c4acece6c498365d1229e4dab65031f €: oh well, guess it's fine cause changed files and commits have my edits, seems like thats just an old state from me messing with my branch |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 211 211
Lines 11089 11089
Branches 1727 1727
=======================================
Hits 9146 9146
Misses 1459 1459
Partials 484 484 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hope this is sufficient, else let me know if you would change something. Bash won't be a login shell but since we clear the enviroment with
sudo -ithis should not have any meaningful impact