Pass parameters for shell function call using an array rather than (unquoted) string substitution #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nquoted) string substitution
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 86.29% 86.28% -0.02%
==========================================
Files 143 143
Lines 7560 7561 +1
==========================================
Hits 6524 6524
- Misses 1036 1037 +1 |
|
I fixed the dumb codestyle checker and the bug reported by the CI. Codecov is wrong on its claim however, as there is no coverage change because of this patch: https://codecov.io/gh/modoboa/modoboa/pull/1608/diff |
|
Bump |
tonioo
reviewed
Jan 21, 2019
| cmd = "sudo -u %s %s" % (sudo_user, cmd) | ||
| kwargs["shell"] = True | ||
| cmd = ["sudo", "-u", sudo_user] + list(cmd) | ||
| kwargs["shell"] = False |
There was a problem hiding this comment.
I don't think it's a good idea to change this value since you did not modify commands to include absolute pathes. If you disable shell mode, PATH resolution won't be available, right?
|
@Alexander255 Could you add a unit test? I don't want your PR (which is useful) to decrease the global coverage ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Modoboa assembles strings for shell commands using string substitution without quoting the parameters, leading, at least potentially (I haven't checked), to vulnerabilities (shell injection).
Current behavior before PR:
Assembling shell parameter lists was broken.
Desired behavior after PR is merged:
Assembling shell parameter lists should not be vulnerable to shell injection attacks.