Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted imap api v1, better pdfcredentials settings validation #2963

Merged
merged 2 commits into from Apr 25, 2023

Conversation

Spitfireap
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #2963 (2183d90) into master (cafb777) will decrease coverage by 0.06%.
The diff coverage is 80.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2963      +/-   ##
==========================================
- Coverage   82.72%   82.66%   -0.06%     
==========================================
  Files         257      254       -3     
  Lines       12698    12681      -17     
  Branches     1921     1922       +1     
==========================================
- Hits        10504    10483      -21     
- Misses       1661     1665       +4     
  Partials      533      533              

@Spitfireap Spitfireap changed the title WIP: delete imap api v1, better pdfcredentials settings validation Deleted imap api v1, better pdfcredentials settings validation Apr 23, 2023
@Spitfireap Spitfireap marked this pull request as ready for review April 23, 2023 15:58
@tonioo tonioo merged commit 9f61b99 into master Apr 25, 2023
12 of 13 checks passed
@tonioo tonioo deleted the Cleaning-and-pdf-qol branch April 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't disable PDF Credentials if directory setting is not valid
2 participants