Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logic that identifies start of each bib item and move through them in verified fashion #48

Closed
jshinm opened this issue Dec 25, 2022 · 0 comments · Fixed by #49
Closed

Add a logic that identifies start of each bib item and move through them in verified fashion #48

jshinm opened this issue Dec 25, 2022 · 0 comments · Fixed by #49
Assignees
@jshinm
Labels
bug Something isn't working update new update to the existing features

Comments

@jshinm
Copy link
Collaborator

jshinm commented Dec 25, 2022

Description of Issue

One edge case where used as email was conflicting with new bib parser logic. Added new generalized validation logic to check for true start of each bib item
@jshinm jshinm added bug Something isn't working update new update to the existing features labels Dec 25, 2022
@jshinm jshinm self-assigned this Dec 25, 2022
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Add new rfindall function that matches all cases and returns indices (#…
7426c3f 
…48)
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Add a pre-processing steps and debug comma issue (#48)
3e87617
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Add idxkey from rfindall_matched function (#48)
311d3d9
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Version update after debugging and update (#48)
2c8fa83
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Re-run notebooks using version 0.0.7 (#48)
3a3624b
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Fresh run using new version (#48)
bc883e5
@jshinm jshinm mentioned this issue Dec 25, 2022
Merged
jshinm added a commit that referenced this issue Dec 25, 2022
@jshinm
Debug item recognition issue (#49)
0460c98 
Associated issue number and/or pull request reference
Fixes #48

Proposed solution to the issue
Debugged the recognition issue by adding a new logic to identify each item of the bib file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshinm jshinm

Labels
bug Something isn't working update new update to the existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Debug item recognition issue modrev-ai/bibReader
1 participant
@jshinm