Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loader and game version detection #45

Merged
merged 4 commits into from
Mar 4, 2023

Conversation

jpenilla
Copy link
Contributor

@jpenilla jpenilla commented Mar 4, 2023

Improves loader detection for loom forks (in general, and also for detecting forge when using architectury-loom), and adds loader detection for when my run-task plugins are applied.

Also applies similar improvements to loom handling to game version detection, and adds paperweight-userdev game version detection.

@jpenilla jpenilla marked this pull request as draft March 4, 2023 00:13
@jpenilla jpenilla changed the title Improve loader detection Improve loader and game version detection Mar 4, 2023
@jpenilla jpenilla marked this pull request as ready for review March 4, 2023 00:22
Copy link
Contributor

@triphora triphora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@triphora triphora merged commit 1876a6b into modrinth:master Mar 4, 2023
jpenilla added a commit to jpenilla/minotaur that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants