Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jar scanner to check files for Fractureiser malware #49

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

hypherionmc
Copy link
Contributor

Implement a built in scanner to check for infections from the Fractureiser malware, before uploading.

The scanner is based on the efforts of this tool

Copy link
Contributor

@triphora triphora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@triphora triphora merged commit 69189d0 into modrinth:master Jun 7, 2023
1 check passed
@douira
Copy link

douira commented Jun 13, 2023

I want to mention that since this PR the detector was updated and some bugs with it were fixed. (such as INVOKEVIRTUAL not being one of the strings in the signature but a typo) See https://github.com/MCRcortex/nekodetector/blob/master/src/main/java/me/cortex/jarscanner/Detector.java for the current state of affairs.

@triphora
Copy link
Contributor

Could the jar scanner maybe be made a library placed on Maven Central? That way we can just pull in the library instead of including it in Minotaur source.

@douira
Copy link

douira commented Jun 13, 2023

Cortex would need to upload the library to Maven Central, I also don't know if this is going to be the long-term solution to the whole static analysis situation. Just wanted to mention that the detector has received some changes for fixing some missed detections.

@hypherionmc
Copy link
Contributor Author

I'll go compare the code and pr the needed changes. Need to update my plugin as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants