Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOSBR mod does not copy options.txt #504

Closed
Madis0 opened this issue Aug 6, 2023 · 2 comments · Fixed by #562
Closed

YOSBR mod does not copy options.txt #504

Madis0 opened this issue Aug 6, 2023 · 2 comments · Fixed by #562
Assignees
Labels
bug Something isn't working

Comments

@Madis0
Copy link

Madis0 commented Aug 6, 2023

Describe the bug

The mod YOSBR does not work fully as intended with Modrinth app. I've filed the issue here and not in the mod's repo because it works as intended with other launchers, such as CurseForge, Prism, MultiMC, GDLauncher...

Steps to reproduce

  1. Install Modrinth app
  2. Create a Fabric instance (e.g. 1.20.1)
  3. Click -> Add content -> search "YOSBR" on Mods -> Install
  4. Go back to home -> right click the instance -> Open folder
  5. Create folder "config", inside that "yosbr", inside that text file "options.txt"
  6. Open the text file and write an option that can easily be tested for, e.g. guiScale:1
  7. Run the instance

Expected behavior

Expected the GUI scale to be 1, as the options.txt file should be copied to root folder by the mod. That, however, does not work.

Additional context

YOSBR can also copy mod config files (not described here), this seems to work.

FYI, this issue is also present on Pojav Launcher, but there at least the options.txt is intentionally overridden to support mobile phones better. In Modrinth app, this is obviously not the goal, so it is a valid bug.

@Madis0 Madis0 added the bug Something isn't working label Aug 6, 2023
@Madis0 Madis0 changed the title YOSBR mod does not fully work YOSBR mod does not copy options.txt Aug 6, 2023
@exelash
Copy link

exelash commented Aug 6, 2023

Can reproduce, YOSBR actually does not work at all.

@thesuzerain thesuzerain self-assigned this Aug 9, 2023
@thesuzerain thesuzerain mentioned this issue Aug 11, 2023
@thesuzerain
Copy link
Contributor

Will be fixed except when laucher settings that override options.txt are toggled on (ie: force fullscreen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants