Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modrinth modpack #63

Closed
Madis0 opened this issue Jun 6, 2021 · 43 comments
Closed

Modrinth modpack #63

Madis0 opened this issue Jun 6, 2021 · 43 comments
Labels
meta Improvements or additions to CF listing, manifest, etc.

Comments

@Madis0
Copy link
Member

Madis0 commented Jun 6, 2021

Create and publish a modpack to Modrinth, because that's where the cool Fabric kids are :)
The files are added per #62, now just needs to be updated and packed when Modrinth adds the support.

https://github.com/modrinth/labrinth/wiki/Modpack-Format

Preferably automatically: packwiz/packwiz#34

Edit: I'll probably do this whenever it's possible, release of FO 2.1.0 won't be affected by this
Edit 2: this is fully automated now, releasing the first mrpacks on Github for testing

@Madis0 Madis0 added the meta Improvements or additions to CF listing, manifest, etc. label Jun 6, 2021
@Madis0 Madis0 added this to the MC 1.17/FO 2.0 milestone Jun 6, 2021
@Madis0 Madis0 mentioned this issue Jun 6, 2021
35 tasks
@Madis0 Madis0 removed this from the MC 1.17/FO 2.0 milestone Jun 10, 2021
@Madis0 Madis0 added this to the MC 1.17.1/FO 2.1.0 milestone Jul 23, 2021
@Madis0 Madis0 added this to To do in 2.1.0 Aug 12, 2021
@Madis0 Madis0 removed this from the MC 1.17.1/FO 2.1.0 milestone Aug 27, 2021
@Madis0 Madis0 removed this from To do in 2.1.0 Aug 27, 2021
@Madis0
Copy link
Member Author

Madis0 commented Feb 10, 2022

Preview is now available: https://knossos-4imn3jq70-emmaffle.vercel.app/modpack/fabulously-optimized

None of the launchers supported by FO can import this format yet.

MultiMC/Launcher#4475
gorilla-devs/GDLauncher#768

@Madis0 Madis0 pinned this issue Feb 15, 2022
@Madis0
Copy link
Member Author

Madis0 commented Feb 28, 2022

Site redesign announced, so the official link is:
https://modrinth.com/modpack/fabulously-optimized

Still, the modpacks aren't publicly listed nor supported by the launchers yet.

@Madis0
Copy link
Member Author

Madis0 commented Mar 11, 2022

Planned launcher:

via

@TiboOpGithub
Copy link

TiboOpGithub commented Mar 12, 2022

That looks good! Currently using it in the regular minecraft launcher (Not so useful when you use 120 mods but ok xD) except for fabulously optimized 1.18.1 but when the modrinth modpacks are out I would use it. If Fabulously Optimized is fast with modrinth modpacks then it will be in the top 10 modrinth modpacks I expect.

@Madis0
Copy link
Member Author

Madis0 commented May 6, 2022

As of May 9th, all existing pack versions should break, due to the new Curseforge API and not allowing to directly link to files.

The current Modrinth availability state as of FO 3.7.0 is 34 out of 48 mods, this is not enough to publish a half-baked pack. It might be worth it to ask the rest of the mods to support Modrinth, but I'm not yet sure this should be a requirement for future FO mod inclusion. Maybe Modrinth will support Curseforge API?

Will let you know of any updates.

Edit: 40 out of 49 are available, thanks DioEzigio for searching!
Edit 2: Packwiz now confirmed that existing urls will not break, so Modrinth existing versions are fine. Any updates still need CF API or MR+GH direct urls.

@Madis0
Copy link
Member Author

Madis0 commented May 16, 2022

Modrinth modpacks are now publicly listed (in Alpha!)
https://modrinth.com/modpacks

  • No official launcher yet, though they have installation instructions for MultiMC development version
  • They are now working on payouts to get more mods onto the platform
  • Still no support for downloads is provided here because it can be unstable and unsustainable for now
  • FO🥇

https://blog.modrinth.com/modpacks-alpha/

@Madis0
Copy link
Member Author

Madis0 commented May 26, 2022

The first integrity test is out! Read more at https://modrinth.com/modpack/fabulously-optimized/version/3.8.2-mr.1

@RaptaG RaptaG mentioned this issue Jun 1, 2022
@Madis0
Copy link
Member Author

Madis0 commented Jun 4, 2022

Second integrity test was done as well and no major imparities were found, so continuing with a (hopefully) more regular release schedule. Do continue reporting any imparities though.

@sarim
Copy link

sarim commented Jun 9, 2022

Modrinth modpack works flawlessly with ferium. (used ferium to install modpack, gdlauncher to play). But didn't work with polymc.

@RaptaG
Copy link
Contributor

RaptaG commented Jun 9, 2022

But didn't work with polymc.

PolyMC is sadly not supported by FO officially yet. Also, this bug is reported in the PolyMC issue tracker so it's going to be fixed soon.

Edit: It's going to be fixed in the version 1.3.2 of PolyMC, with this Pull Request.

@sarim
Copy link

sarim commented Jun 9, 2022

Good to know. Whats the officially supported launcher? ferium was working yesterday, but today its downloading the 1.18.2 version. There's no way to specify version.

@Madis0
Copy link
Member Author

Madis0 commented Jun 9, 2022

Good to know. Whats the officially supported launcher? ferium was working yesterday, but today its downloading the 1.18.2 version. There's no way to specify version.

See https://fabulously-optimized.gitbook.io/modpack/readme/install-instructions
Modrinth is currently not supported at all as it can have bugs and inconsistencies, is there just for testing.

@Madis0
Copy link
Member Author

Madis0 commented Jun 17, 2022

3.10.0 and few other latest versions had Don't Clear Chat History missing due to a bug in the script. That version has been re-uploaded as -mr.1 and the 4.0.0-beta.1 has it fixed.

On a general note, Modrinth support by FO is waiting on:

@Madis0 Madis0 unpinned this issue Jun 23, 2022
@Madis0
Copy link
Member Author

Madis0 commented Jul 9, 2022

As of 4.0.0-beta.8, Modrinth version no longer includes JARs!
This means that it is becoming becoming more sustainable as a platform because mods are cross-posting to it.
(Though obviously things can still change in the future versions if some mod does not post to Modrinth as fast as it does to other platforms.)

@Madis0
Copy link
Member Author

Madis0 commented Jul 22, 2022

Another step for parity!
4.0.0-beta.11 removed Don't Clear Chat History, so CF and MR users will have near-identical set of mods now (except for Farsight, still).

@RaptaG
Copy link
Contributor

RaptaG commented Jul 22, 2022

Yeah!

@nsde
Copy link
Contributor

nsde commented Sep 10, 2022

Is this issue still needed? I'm asking because there is a Modrinth modpack for FO.

@osfanbuff63
Copy link
Member

Is this issue still needed? I'm asking because there is a Modrinth modpack for FO.

Yes, because Modrinth downloads are still experimental. If I understand correctly, we're mostly waiting to add support for launchers like PolyMC (#456, waiting on PolyMC/PolyMC#60), and then we should be good to remove the experimental notice and close this issue.

@nsde
Copy link
Contributor

nsde commented Sep 10, 2022

OK!

@Madis0
Copy link
Member Author

Madis0 commented Sep 16, 2022

Another step for sustainability: MultiMC (auto-update) now prefers Modrinth mods!
That way the downloads actually increase download count for the dev and you get more stable, potentially faster downloads!

@nsde
Copy link
Contributor

nsde commented Sep 16, 2022

Sounds great :)

@nsde
Copy link
Contributor

nsde commented Sep 16, 2022

Especially because I like Modrinth. It's open source afterall :)

@Madis0
Copy link
Member Author

Madis0 commented Nov 1, 2022

Fabulously Optimized now supports Prism Launcher and Modrinth downloads! The issue will still be kept open for Modrinth Launcher news, whenever that comes.

@arthomnix
Copy link

Is there any reason Modrinth isn't supported on MultiMC? It seems to work fine

@Madis0
Copy link
Member Author

Madis0 commented Nov 20, 2022

Is there any reason Modrinth isn't supported on MultiMC? It seems to work fine

Yes:

  • CurseForge downloads benefit me financially, and are a familiar place for people to download from
  • MultiMC has no modpack updater feature, so an auto-update pack has been provided in GitHub to workaround that
  • MultiMC stable currently has a broken modpack downloader from Modrinth, meaning you can only download the latest stable version (have a try lol)
  • There is still a slight imparity in CF vs MR versions (Farsight vs Hold That Chunk), so MultiMC users can get the same mods as most other launchers
  • Overall I want to support only one (best) source per launcher to make providing support consistent

@arthomnix
Copy link

It looks like MultiMC is getting Curseforge pack import support again soon, will that be supported?

@Madis0
Copy link
Member Author

Madis0 commented Nov 20, 2022

It looks like MultiMC is getting Curseforge pack import support again soon, will that be supported?

I don't think so. Downloading from CurseForge via an API nowadays does not even increase the download count, and some mods need to be downloaded manually.

@arthomnix
Copy link

Any reason Modrinth downloads are supported on Prism, since some of those problems still apply? Is it just because they have a modpack updater?

@Madis0
Copy link
Member Author

Madis0 commented Nov 20, 2022

Yes, they have a working modpack downloader and updater 😄
I hope to close the gap between CF and MR ASAP though.

@arthomnix
Copy link

Is MR support on MultiMC going to be considered once the working pack downloader is stable, since the default MultiMC pack isn't updatable anyway?

@osfanbuff63
Copy link
Member

Is MR support on MultiMC going to be considered once the working pack downloader is stable, since the default MultiMC pack isn't updatable anyway?

From above:

  • Overall I want to support only one (best) source per launcher to make providing support consistent

@arthomnix
Copy link

There are already two sources for MultiMC (the normal and auto-updating versions), it may be easier to replace the normal version with MR (once the fixed pack downloader goes stable) since that's already supported for Prism anyway

@Madis0
Copy link
Member Author

Madis0 commented Nov 20, 2022

Then vanilla users would be troubled...
There is not much difference whether I would distribute that for vanilla as just a set of three folders or one that's compatible with something 😄

Anyway, this discussion is getting long so I'd encourage you to join our Discord so we can communicate back and forth faster.

@RaptaG
Copy link
Contributor

RaptaG commented Mar 25, 2023

Wait, why isn't this closed? Modrinth is fully supported now, isn't it?

@osfanbuff63
Copy link
Member

Yes, as Prism relies on it. I think this is safe to close.

@Madis0
Copy link
Member Author

Madis0 commented Mar 25, 2023

Modrinth Launcher is missing.

@RaptaG
Copy link
Contributor

RaptaG commented Mar 25, 2023

Oh

@Madis0
Copy link
Member Author

Madis0 commented Apr 22, 2023

Per #627, MultiMC users are now also advised to download from Modrinth instead of CurseForge.

@Madis0
Copy link
Member Author

Madis0 commented Aug 6, 2023

Modrinth App now in open beta

The Modrinth App is now in open beta! If you already have it, make sure to accept the update prompt.

Among other things, it now allows importing instances from other launchers. In my testing, the Modrinth-based instances of FO on other launchers are also updatable on Modrinth App 🎉

Update blog post

Preliminary install/update/etc instructions for FO

Things to test for:

  • Was your Java detected automatically? Note that this doesn't mean it'll be installed automatically if you don't have it.
  • Linux users - how smooth is the installation on your distro? Are you satisfied with the provided options? Give feedback on #497

Known issues:

  • FO's options.txt defaults are not currently applied (#504)
  • If you want to change mods, you can't auto-update the modpack later (#505)
  • There is no way to see what modpack version you have installed (#503)
  • Cannot upgrade to a specified version (e.g. latest for 1.19.4 instead of 1.20.1) (#194)

Once the app is stable and the aforementioned known issues are fixed, it will be officially supported by FO :)

@Madis0 Madis0 pinned this issue Aug 6, 2023
@Madis0
Copy link
Member Author

Madis0 commented Sep 17, 2023

Modrinth App 0.5.4

Modrinth App has been updated and all previously known blocking issues have been fixed.

Are there any new ones? Try it out and let me know! If not, then we might just start supporting it soon enough.

📜 Changelog

FO Preliminary instructions: Install | Update | Add mods | Disable mods

Remember, if your launcher UI does not match the instructions above, you're on an older version, so update it first!
Unfortunately, you can't yet check which launcher version you're running, see #737.

and also #656 is finally planned for 5.4.0, which would bring full parity between CurseForge and Modrinth.

So, during the 5.4.0 testing period the Modrinth App can continue to get improvements and when done, it would make sense to release 5.4.0 and Modrinth App support together.


It is also possible that Modrinth App will become the no. 1 recommended launcher for FO, because it supports FO well and literally promotes it as the first on homepage 😛 But I think that may need to wait a bit more while it gets a full stable release overall, to avoid disappointing users with bugs.

@Madis0
Copy link
Member Author

Madis0 commented Oct 6, 2023

As of 5.4.0, full parity has been achieved 🎉 (version bump was done and 1.20.2 will now be 5.5.0 instead)
Modrinth App is still in beta though, so I'm still testing and considering that.

@Madis0
Copy link
Member Author

Madis0 commented Nov 18, 2023

Very interesting stats:
image

My interpretation

  • Modrinth is growing by a lot lately
  • Modrinth-compatible launchers don't care about betas
  • Modrinth still lacks the archival options, which skews the download stats of older (major) versions :(

I plan to support Modrinth App when the version indicator gets released (for my support purposes), and make it the first when it moves out of beta (because some people are still having issues with logins and Linux stuff).

@Madis0
Copy link
Member Author

Madis0 commented Nov 22, 2023

Fabulously Optimized now supports Modrinth App!

The app is still in beta, but I think it is in a usable state for most.

@Madis0 Madis0 closed this as completed Nov 22, 2023
@Madis0 Madis0 unpinned this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Improvements or additions to CF listing, manifest, etc.
Projects
None yet
Development

No branches or pull requests

7 participants