Add option to disable certain workers #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables worker markers and circles if they are in config.DISABLE_MARKERS
disables workers listed in config.DISABLE_MARKERS
This was referenced Aug 16, 2016
| @@ -9,6 +9,7 @@ LANGUAGE = 'EN' # ISO 639-1 codes EN, DE, FR, and ZH currently supported. | |||
| MAP_START = (12.3456, 34.5678) | |||
| MAP_END = (13.4567, 35.6789) | |||
| GRID = (2, 2) # row, column | |||
| # DISABLE_MARKERS = [0, 1, 2] | |||
There was a problem hiding this comment.
For better sounding, please name it DISABLED_WORKERS. It can also be initialized as an empty list (without # indicating comment).
Please also add it to REQUIRED_SETTINGS in both worker.py and web.py (at the top).
There was a problem hiding this comment.
It's like you read my mind. I just noticed not having it in your settings would cause problems, and I was thinking the same about the name.
There was a problem hiding this comment.
Or treat it as an optional config value, and do not require another config update:
if (not hasattr(config, 'DISABLE_MARKERS') or worker_no not in config.DISABLE_MARKERS):
Is it bad approach?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISABLE_MARKERS = []
in config