Add linear equation of state #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inned sorting indices
|
@gunnarvoet I saw that v0.1.1 is released! Awesome! I think this PR is ready to go now, shall I merge? |
|
Yes, I got v0.1.1 out yesterday =) One thing you could do before merging is to add to the history section. I think it would be good for us to make this a habit so we have good documentation of what changes from version to version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a linear equation of state, with unit tests, and updated the documentation.
When finished, this will close #74. I think it should maybe close #77, which I found too difficult to complete (there are too many possible logical combinations of parameters to completely refactor the buoyancy frequency calculation). I think #77 needs a new approach.
Additionally, this adds pressure bin width as an optional parameter, which kind of addresses #73.