Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix solution dimensions for lumped rate model with pores #133

Closed
schmoelder opened this issue Jun 20, 2023 · 0 comments · Fixed by #137
Closed

Fix solution dimensions for lumped rate model with pores #133

schmoelder opened this issue Jun 20, 2023 · 0 comments · Fixed by #137
Labels
dev-call

Comments

@schmoelder
Copy link
Contributor

Currently, the particle/solid phase dimension has a singleton dimension for nparshells even though nparshells can never be larger than 1.
This is not consistent with other units.
E.g. a GRM has no singleton dimension for nrad.
Also, this is a breaking change in the interface that came when updating the solution recorder from push to pull.

@sleweke already had some idea how to fix this, right? 🤓
sleweke-bayer added a commit to sleweke-bayer/CADET that referenced this issue Jul 21, 2023
@sleweke-bayer
Remove singleton parshell dims in solution of LRMP, CSTR
eeafb20 
Restores the previous behavior when reporting the solution of the LRMP
and CSTR units: The singleton particle shell dimension is removed from
the output tensor.

Fixes modsim#133.
@sleweke-bayer sleweke-bayer mentioned this issue Jul 21, 2023
Merged
jbreue16 pushed a commit that referenced this issue Jul 24, 2023
@sleweke-bayer @jbreue16
Remove singleton parshell dims in solution of LRMP, CSTR
75ba0e7 
Restores the previous behavior when reporting the solution of the LRMP
and CSTR units: The singleton particle shell dimension is removed from
the output tensor.

Fixes #133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-call
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove singleton parshell dims in solution of LRMP, CSTR sleweke-bayer/CADET
1 participant
@schmoelder