Fix consistent initial state for linear isotherm. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was assumed that the linear algebraic equations are easily solved, not requiring a full nonlinear solver. However, it was shown that this can lead to situations in which mass is not conserved. To fix this, even this simple model needs to be fully initialized.
schmoelder
force-pushed
the
fix/linear_consistent_initialization
branch
from
fdff6c6
to
1ec5abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Previously, it was assumed that the linear algebraic equations are easily solved, not requiring a full nonlinear solver.
However, it was shown that this can lead to situations in which mass is not conserved.
To fix this, even this simple model needs to be fully initialized.
As suggested by @Immudzen , I also timed the function and could not see a significant performance loss.
@sleweke We might want to check other models that implement this method, like SMA