Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radial flow for chromatography column models #120

Merged
merged 5 commits into from
May 3, 2024
Merged

Radial flow for chromatography column models #120

merged 5 commits into from
May 3, 2024

Commits on May 2, 2024

  1. Add "axial" to convection dispersion operator name 

    Co-authored-by: jbreue16 <jan.breuer@fz-juelich.de>
    @sleweke @jbreue16
    sleweke and jbreue16 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e05f880 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Add radial flow chromatography column models (FV) 

    Spatial FV discretization units only

Co-authored-by: jbreue16 <jan.breuer@fz-juelich.de>
    @sleweke @jbreue16
    sleweke and jbreue16 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0eb8948 View commit details
    Browse the repository at this point in the history

  2. Add infra for parameter-parameter dependencies 

    Adds infrastructure code (e.g., factories, interfaces) to allow
parameters to depend on other parameters.

Co-authored-by: jbreue16 <jan.breuer@fz-juelich.de>
    @sleweke @jbreue16
    sleweke and jbreue16 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1f3adfe View commit details
    Browse the repository at this point in the history

  3. Add identity parameter-parameter dependence 

    Adds a parameter dependence that simply outputs the given parameter
value.
    @sleweke-bayer @jbreue16
    sleweke-bayer authored and jbreue16 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    baab1a5 View commit details
    Browse the repository at this point in the history

  4. Add first parameter dependencies to chromatography models 

    Add radial flow and parameter dependence support to createLWE

Axial dispersion for all FV units, film diffusion parameter dependence for LRMP FV unit

Add tests for radial flow convection dispersion operators

Enable radial dispersion coeff dependency in operators

Parameter dependencies are work in progress and the interfaces might change up until the next release

Co-authored-by: jbreue16 <jan.breuer@fz-juelich.de>
    @sleweke-bayer @jbreue16
    sleweke-bayer and jbreue16 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1ec9150 View commit details
    Browse the repository at this point in the history