Changed file LangmuirLDFBinding #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for your PR. For consistency, could you please revert the changes to the parameter names? I know it's superfluous, but currently we would like to stick to the convention of a parameter prefix (i.e. Also, it might be a good idea to add some tests s.t. we can be more confident with the implementation. If you need help, please feel free to reach out or to visit on of our upcoming Office Hours. |
|
Dear Johannes,
Thank you for your email. Sorry for the late reply, I was out of office
until today. I will revise the code and I will let you know.
Best,
Kostas
…On Sun, 24 Mar 2024, 08:42 Johannes Schmölder, ***@***.***> wrote:
Hi and thanks for your PR. For consistency, could you please revert the
changes to the parameter names? I know it's superfluous, but currently we
would like to stick to the convention of a parameter prefix (i.e. MCLLDF_
).
Also, it might be a good idea to add some tests s.t. we can be more
confident with the implementation. If you need help, please feel free to
reach out or to visit on of our upcoming Office Hours
<https://forum.cadet-web.de/t/introducing-office-hours/518>.
—
Reply to this email directly, view it on GitHub
<#171 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEAHZOR4YTOMCS5PKCEL4ITYZ2GYTAVCNFSM6AAAAABDXDMEEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWG4ZTOMRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi I committed the changes to the code. After a few tests I've done on Python, it seems to run smoothly. |
|
Hi, thanks for your input. Could you please also add tests and documentation to your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly transformed equilibrium approach to the Langmuir isotherm that accounts for gradient conditions. When disabling kinetics IS_KINETIC = 0, kkin has still an impact on the output.
Edit: This PR is a follow-up to a discussion in our Forum.