Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: regression with modular install --install-version #1887

Closed
guidorice opened this issue Mar 5, 2024 · 1 comment
Closed

[BUG]: regression with modular install --install-version #1887

guidorice opened this issue Mar 5, 2024 · 1 comment
Labels
bug Something isn't working modular-cli modular tool issues mojo Issues that are related to mojo mojo-repo Tag all issues with this label

Comments

@guidorice
Copy link

guidorice commented Mar 5, 2024

Bug description

--install-version was added to support version pinning of mojo, ex: in CI/CD environments. I have been using this successfully in the mojo-pytest project.
With 24.1 this version pinning no longer works. Tried on both MacOS and also the Github Actions runner (Linux)

Steps to reproduce

$ modular install --install-version 24.1.0 mojo
modular: error: no packages found for the current target hardware - please run `modular host-info` and file a ticket at https://github.com/modularml/max with your hardware information

$ modular host-info

 Host Information
  ================

  Target Triple: aarch64-unknown-macosx
  CPU: apple-m1
  CPU Features: aes, complxnum, crc, dotprod, fp-armv8, fp16fml, fullfp16, jsconv, lse, neon, pauth, ras, rcpc, rdm, sha2, sha3

System information

Darwin macbook.local 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:33:31 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T8112 arm64
mojo 24.1.0 (55ec12d6)
modular 0.5.1 (1b608e3d)
@guidorice guidorice added bug Something isn't working mojo Issues that are related to mojo labels Mar 5, 2024
@zbowling
Copy link

zbowling commented Mar 15, 2024

You can use modular install mojo --install-version 24.1.0-55ec12d6-release. The command doesn't understand how to parse partial version numbers and requires fully qualified versions which have become more verbose as of late. You can get the full version string from more recent mojo packages by reading the VERSION file in the ~/.modular/pkg/packages.modular.com_mojo/ folder.

Please note that the --install-version flag was more for field testing and debugging user issues and less a supported feature like for CI/CD environments. We don't make guarantees with it and won't until Mojo stabilizes and we have a more long term supported version of Mojo. Older packages of Mojo may stop working with newer versions of the modular CLI at any point because the contract between packages and the Modular CLI is still evolving (generally the CLI is backward compatible with a version or two but anything older is not guaranteed to work).

@zbowling zbowling added the modular-cli modular tool issues label Mar 15, 2024
@ematejska ematejska added the mojo-repo Tag all issues with this label label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modular-cli modular tool issues mojo Issues that are related to mojo mojo-repo Tag all issues with this label
Projects
None yet
Development

No branches or pull requests

3 participants