Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Make the msg argument of assert_true/false/... keyword only #2487

Open
1 task done
soraros opened this issue May 3, 2024 · 1 comment
Open
1 task done

[Feature Request] Make the msg argument of assert_true/false/... keyword only #2487

soraros opened this issue May 3, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers mojo-repo Tag all issues with this label mojo-stdlib Tag for issues related to standard library

Comments

@soraros
Copy link
Contributor

soraros commented May 3, 2024

Review Mojo's priorities

What is your request?

As title.

What is your motivation for this change?

To prevent #2475 from happening again.

Any other details?

I think it's a good first issue.
@soraros soraros added enhancement New feature or request mojo-repo Tag all issues with this label labels May 3, 2024
@JoeLoser JoeLoser added good first issue Good for newcomers mojo-stdlib Tag for issues related to standard library labels May 3, 2024
@softmaxer
Copy link

I'm currently on this and as I'm looking through it, most of the assert functions already had msg: String = "" in place. Except for maybe 2 functions. So I added that. Is that the issue or am I completely missing something here?

@softmaxer softmaxer mentioned this issue May 3, 2024
Closed
@ematejska ematejska removed the mojo-stdlib Tag for issues related to standard library label May 6, 2024
@ematejska ematejska added the mojo-stdlib Tag for issues related to standard library label May 7, 2024 — with Linear
@softmaxer softmaxer mentioned this issue May 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers mojo-repo Tag all issues with this label mojo-stdlib Tag for issues related to standard library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@soraros @JoeLoser @ematejska @softmaxer