Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Typo in K-Means Clustering Guide Posted May 20, 2024 #2840

Closed
kasmith11 opened this issue May 26, 2024 · 1 comment
Closed

[Docs] Typo in K-Means Clustering Guide Posted May 20, 2024 #2840

kasmith11 opened this issue May 26, 2024 · 1 comment
Labels
mojo-repo Tag all issues with this label

Comments

@kasmith11
Copy link

Where is the problem?

Location of Typo

What can we do better?

In the section Calculating squared Euclidean distance Python+NumPy and Mojo there is a reference to k-means plus plus when I believe it should make reference to squared Euclidean distance:

"Below is Python and Mojo implementation of k-means plus plus algorithm (click to zoom, best viewed when browser is full screen). The red boxes show what changes we needed to make to port code over to Mojo."

Anything else?

No response

@kasmith11 kasmith11 added documentation Improvements or additions to documentation mojo-repo Tag all issues with this label labels May 26, 2024
@ematejska ematejska removed the documentation Improvements or additions to documentation label May 28, 2024
@hogepodge
Copy link
Collaborator

Looking at the code and the algorithm, I don't think that there's anything incorrect about what was written. The code as written looks in line with the k-means++ algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mojo-repo Tag all issues with this label
Projects
None yet
Development

No branches or pull requests

3 participants