Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciate original mixin #10

Closed
scottkellum opened this issue Aug 19, 2011 · 11 comments
Closed

Depreciate original mixin #10

scottkellum opened this issue Aug 19, 2011 · 11 comments

Comments

@scottkellum
Copy link
Member

Seems superfluous now to have both the function and original mixin. The function is far more versatile and is easier to write.

@codingdesigner
Copy link
Contributor

I think you're right. I was thinking it was there for people who are more comfortable with mixins, but that's kind of a crutch, right?

@scottkellum
Copy link
Member Author

Functions are better, they should learn them. Lets get rid of it.

@adamstac
Copy link
Contributor

If we do, don't forget that the classes mixin uses this https://github.com/scottkellum/modular-scale/blob/master/stylesheets/_modular-scale.sass#L208

@scottkellum
Copy link
Member Author

I was about to delete it but then saw the classes mixin and the regular mixin next to each other. Might as well leave it in as they have a lot of similarities.

@codingdesigner
Copy link
Contributor

It's still a bit vestigial. I'm still thinking of taking it out, and rewriting the classes mixin accordingly. Should be a pretty simple change.

@adamstac
Copy link
Contributor

Yea, the classes mixin can get re-written accordingly to use the function instead.

codingdesigner added a commit that referenced this issue Aug 23, 2011
… a warning to the console, but still work.

#10

passing a selector into a mixin like that feels so 2010
@codingdesigner
Copy link
Contributor

I went ahead and deprecated it. For now running the mixin will send a warning to the console, but still work.

@adamstac
Copy link
Contributor

Which brings up a topic we should mention for extension devs, when to use @debug and @warn.

@scottkellum
Copy link
Member Author

So many new things to learn.

@codingdesigner
Copy link
Contributor

good point. I'd love to draft something on that. I'd be lost w/o @debug

@adamstac
Copy link
Contributor

I have a start to a guide on if, for, each, while that has some uses of this in the code samples but nothing that dives into the subject. Take a peek at the read lists and feel free to add to them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants