Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect results with some negative multiples when base is a list. #33

Closed
atadams opened this issue Oct 11, 2012 · 3 comments
Closed

Incorrect results with some negative multiples when base is a list. #33

atadams opened this issue Oct 11, 2012 · 3 comments

Comments

@atadams
Copy link

atadams commented Oct 11, 2012

I believe 2c23acf introduced an error with certain negative multiples when the base is a list.

Example ms(-2, 16px 44px, 1.618, false); should equal 9.88875px (see ModularScale.com) but equals 6.11171px.

Actually the multiples -2, -3, and -4 with these settings all equal 6.11171px.
scottkellum added a commit that referenced this issue Dec 30, 2012
@scottkellum
testing #33
aa81184
@KiTo
Copy link

KiTo commented Feb 14, 2013

Can confirm problem.

@scottkellum
Copy link
Member

The issue is confirmed, just very difficult to fix.

@scottkellum scottkellum mentioned this issue Mar 4, 2013
Closed
@scottkellum
Copy link
Member

Should be fixed in 2.0. Please reopen if it isn’t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KiTo @scottkellum @atadams